Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

PP-11883 Update cancel link to be a button #3924

Merged
merged 1 commit into from
Oct 25, 2024

Conversation

iqbalgds
Copy link
Contributor

@iqbalgds iqbalgds commented Oct 24, 2024

  • The cancel link on the payment and confirm pages appears like a link but is semantically a button.
  • This can cause confusion for users using assitive tech.
  • This PR changes the link so that it is a secondary action button.
  • Also got rid of SASS that is no longer required.

New styling below:

image

SandorArpa
SandorArpa previously approved these changes Oct 24, 2024
Copy link
Contributor

@SandorArpa SandorArpa left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@iqbalgds iqbalgds force-pushed the pp-11883-update-cancel-link branch 2 times, most recently from d0f1627 to 178abe9 Compare October 24, 2024 14:48
- The cancel link on the payment and confirm pages appears like a link but is semantically a button.
- This can cause confusion for users using assitive tech.
- This PR changes the link so that it is a secondary action button.
- Also got rid of SASS that is no longer required.
@iqbalgds iqbalgds force-pushed the pp-11883-update-cancel-link branch from 178abe9 to d45d0bf Compare October 24, 2024 15:00
Copy link
Contributor

@SandorArpa SandorArpa left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@iqbalgds iqbalgds merged commit b08f19e into master Oct 25, 2024
11 checks passed
@iqbalgds iqbalgds deleted the pp-11883-update-cancel-link branch October 25, 2024 11:30
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants